rust: enhance PointerWrapper.
#386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
v1 -> v2
|
TheSven73
reviewed
Jun 23, 2021
rust/kernel/types.rs
Outdated
| // so it is safe to dereference the raw pointer. | ||
| // The safety requirements also ensure that the object remains alive for the lifetime of | ||
| // the returned value. | ||
| unsafe { UnsafeReference::new(&*(ptr as *const T)) } |
There was a problem hiding this comment.
Nit: left out a cast() here?
There was a problem hiding this comment.
Oops. I had missed this one because it goes away when I update Ref's implementation.
Anyway, fixed it now. PTAL.
This formalises how wrapped values can be accessed after they've been converted to 'pointers'. In upcoming PRs, we will have `Box<T>` instances access `&T`, but `Ref<T>` will provide access to `&Ref<T>` so that we can increment the refcount when needed. Signed-off-by: Wedson Almeida Filho <[email protected]>
|
Review of
|
TheSven73
reviewed
Jun 23, 2021
| /// | ||
| /// `ptr` must have been returned by a previous call to [`PointerWrapper::into_pointer`]. | ||
| /// Additionally, [`PointerWrapper::from_pointer`] can only be called after *all* values | ||
| /// returned by [`PointerWrapper::borrow`] have been dropped. |
There was a problem hiding this comment.
Are there a couple of safety constraints we've omitted here?
Following these # Safety instructions, are we allowed to:
- call
from_pointer()multiple times on the same pointer? - call
borrow()after the call tofrom_pointer()?
If so, does this merit a follow-up PR?
There was a problem hiding this comment.
Yes, this should be clarified. I'll prepare a follow-up PR.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formalises how wrapped values can be accessed after they've been
converted to 'pointers'.
In upcoming PRs, we will have
Box<T>instances access&T, butRef<T>will provide access to&Ref<T>so that we can increment therefcount when needed.
Signed-off-by: Wedson Almeida Filho [email protected]