Skip to content

rust: compile libcore with no_fp_fmt_parse #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

nbdd0121
Copy link
Member

This option removes floating point formatting/parsing support in libcore, thus allows us to remove the intrinsics stubs in compiler_builtins.rs and saves some space.

   text	   data	    bss	    dec	filename
6282838	2277360	 296600	8856798	w/o `no_fp_fmt_parse`
6235608	2250128	 296600	8782336	w/  `no_fp_fmt_parse`

This option removes floating point formatting/parsing support in
`libcore`, thus allows us to remove the intrinsics stubs in
`compiler_builtins.rs` and saves some space.

   text	   data	    bss	    dec	filename
6282838	2277360	 296600	8856798	w/o `no_fp_fmt_parse`
6235608	2250128	 296600	8782336	w/  `no_fp_fmt_parse`

Signed-off-by: Gary Guo <[email protected]>
@ojeda
Copy link
Member

ojeda commented Oct 11, 2021

Thanks a lot for adding this upstream.

For reference: rust-lang/rust#86048

@ojeda ojeda merged commit 4cb694e into Rust-for-Linux:rust Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants