rust: kernel: use feature individually
#636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rustfmt` (in its default config, at least) does not add a comma in the last feature of the list, which means diffs are bigger at times. In addition, this is how the standard library does it, and one may argue it allows for easier `grep`ing too. Link: Rust-for-Linux#439 (comment). Indirectly-suggested-by: Benoit de Chezelles <[email protected]> Signed-off-by: Miguel Ojeda <[email protected]>
bjorn3
approved these changes
Jan 20, 2022
|
Thanks @bjorn3 for the review as usual! Yeah, exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustfmt(in its default config, at least) does not add a commain the last feature of the list, which means diffs are bigger at times.
In addition, this is how the standard library does it, and one
may argue it allows for easier
greping too.Link: #439 (comment).
Indirectly-suggested-by: Benoit de Chezelles [email protected]
Signed-off-by: Miguel Ojeda [email protected]