Split bindings crate out of the main kernel crate #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add rustdoc or testing code for the bindings crate as I didn't think it would be necessary. It already wasn't documented thanks to |
bjorn3
force-pushed
the
split_bindings_off
branch
2 times, most recently
from
1022121 to
65101b9
Compare
|
How do I add a dependency on bindings to kernel for rustdoc tests? |
ojeda
reviewed
Jul 9, 2022
This should solve the CI issue: @@ -129,6 +129,9 @@ quiet_cmd_rustc_test_library = RUSTC TL $<
-L$(objtree)/$(obj)/test \
--crate-name $(subst rusttest-,,$(subst rusttestlib-,,$@)) $<
+rusttestlib-bindings: $(src)/bindings/lib.rs rusttest-prepare FORCE
+ $(call if_changed,rustc_test_library)
+
rusttestlib-build_error: $(src)/build_error.rs rusttest-prepare FORCE
$(call if_changed,rustc_test_library)
@@ -239,7 +242,7 @@ rusttest-macros: $(src)/macros/lib.rs rusttest-prepare FORCE
rusttest-kernel: private rustc_target_flags = --extern alloc \
--extern build_error --extern macros --extern bindings
rusttest-kernel: $(src)/kernel/lib.rs rusttest-prepare \
- rusttestlib-build_error rusttestlib-macros FORCE
+ rusttestlib-bindings rusttestlib-build_error rusttestlib-macros FORCE
$(call if_changed,rustc_test)
$(call if_changed,rustc_test_library) |
bjorn3
force-pushed
the
split_bindings_off
branch
from
65101b9 to
7eeb0e3
Compare
The generated bindings are mostly static when working on new rust abstractions. By splitting them off the main kernel crate, recompilation of the main kernel crate takes ~2s rather than ~12s. While this loses some optimizations without LTO, the fast majority of the binding functions are already marked as `#[inline]`. Pretty much only `Default` impls aren't marked as such. The cost of not inlining those `Default` impls is likely neglectable. Signed-off-by: Björn Roy Baron <[email protected]>
Signed-off-by: Björn Roy Baron <[email protected]>
bjorn3
force-pushed
the
split_bindings_off
branch
from
7eeb0e3 to
521024c
Compare
|
CI passes now. |
|
Great work! |
|
Had just a type alias on which I implemented my stuff. Guess I have to change that now, as I can't implement for types outside the crate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated bindings are mostly static when working on new rust
abstractions. By splitting them off the main kernel crate, recompilation
of the main kernel crate takes ~2s rather than ~12s. While this loses
some optimizations without LTO, the fast majority of the binding
functions are already marked as
#[inline]. Pretty much onlyDefaultimpls aren't marked as such. The cost of not inlining thoseDefaultimpls is likely neglectable.Signed-off-by: Björn Roy Baron [email protected]