Skip to content

Get bindgen libclang version correctly #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jordanisaacs
Copy link

Currently the way to retreive the bindgen libclang version is susceptible to versions within the path. This commit fixes that by using tail rather than head on the version results. Fixes #942 .

@ojeda
Copy link
Member

ojeda commented Jan 9, 2023

Thanks Jordan! I have been improving the script, and for this, we need to match clang version before the version so that we are sure to take only the immediately one after that and not anything else anywhere it may be (like we already do for another match in the file). In addition, using tail would not work for the ...clang version 13.0.0 (Fedora 13.0.0-3.fc35)... case for which the head was added by #789.

I submitted the other approach at: https://lore.kernel.org/rust-for-linux/[email protected]/ with your Reported-by. It would be nice if you could give that patch a test on your side too (you can submit then a Tested-by tag).

In any case, please note that patches to the kernel need to be signed according to the DCO (see https://www.kernel.org/doc/html/latest/process/submitting-patches.html), i.e. they require a Signed-off-by with the real name and so on.

@ojeda
Copy link
Member

ojeda commented Jan 10, 2023

@jordanisaacs In the patch above I used your GitHub handle and the name as in your profile for the Reported-by tag, but it would be nice to have at least your email, and ideally your real name too. Do you want me to use the one from the author field of the commit here? Or something else? I will Cc you on the patch there if you provide it to me.

@jordanisaacs
Copy link
Author

@ojeda Couldn't apply the single patch so applied the entire patchset and for this specific issue can confirm it is fixed! Yep the author/name fields in the commit work. So "Jordan Isaacs" and mail [at] jdisaacs.com. If you could CC me that would be great and I will send a tested-by.

@ojeda
Copy link
Member

ojeda commented Jan 13, 2023

Thanks Jordan! Cc'ing you there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

libclang bindgen version check fails when version is in path
2 participants