feat: add focus handling to macOS view for proper key event forwarding #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `add_mouse_button_class_method!` macro. Now, when `$foc` is true, the code calls `makeFirstResponder` on the window to ensure the view becomes the first responder. This change enables the plugin view to properly capture keyboard input on macOS.
|
Fixes #191. |
|
While we are at it, I believe I am seeing the same issue in Windows. Is that expected? Where would I look if I wanted to fix that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
add_mouse_button_class_method!macro.Now, when
$focis true, the code callsmakeFirstResponderon the window to ensure the view becomes the first responder.This change enables the plugin view to properly capture keyboard input on macOS.
Credit to @justinfrankel. See #202.