Maintainer quality-of-life improvements (CI, auto-publising, docs for apple-darwin, testing). #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since switching from macOS to Linux for my daily device, it's been trickier to get the chance to test and publish changes here and on coreaudio-rs. This PR aims to make it easier for myself, the rustaudio devs and new contributors to land changes in the repo.
CI
I've switched the CI from travis over to github, mostly because I personally find it a little easier to use and I already kind of know how to enable auto-publishing using github workflows. The CI has also been updated to check a few different permutations of features (default, none, all), checks that the docs can be built and also checks that cross-compiling from Linux is working. Edit: cross-compiling is currently not working, but will open a follow-up PR with my WIP.
Auto-publish
From when this PR lands and onwards, when a commit is pushed to master (e.g. when merging a PR) the changes will automatically be published to crates.io provided that the version was incremented in the Cargo.toml.
Docs
The docs for the coreaudio-rs/sys crates have been unusable so far. A while back, docs.rs gained the ability to change the default target that is presented to visitors of the site. This PR changes coreaudio-sys' default to
x86_64-apple-darwin.