Move modular module to toplevel
#324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously located under `uint`. Now that we've begun work to share the implementation between `Uint` and `BoxedUint`, moving this module to the toplevel makes sense. It also better maps to the public API, where it's re-exported from the toplevel, i.e. this is not a breaking change. Finally, less nesting makes the codebase easier to navigate.
tarcieri
force-pushed
the
move-modular-to-toplevel
branch
from
ce4cf39 to
a2b078b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously located under
uint.Now that we've begun work to share the implementation between
UintandBoxedUint, moving this module to the toplevel makes sense.It also better maps to the public API, where it's re-exported from the toplevel, i.e. this is not a breaking change.
Finally, less nesting makes the codebase easier to navigate.