Add Zero::set_zero method
#426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method to the `Zero` trait for setting its value to zero in-place, subsuming the previous `BoxedUint::set_to_zero` function. It's inspired by a similar method on `num_traits::Zero` (which we don't use so `is_zero` can return `Choice` and use `ConstantTimeEq` to compare values in constant-time). https://docs.rs/num-traits/latest/num_traits/identities/trait.Zero.html#method.set_zero
xuganyu96
pushed a commit
to xuganyu96/crypto-bigint
that referenced
this pull request
Dec 15, 2023
Adds a method to the `Zero` trait for setting its value to zero in-place, subsuming the previous `BoxedUint::set_to_zero` function. It's inspired by a similar method on `num_traits::Zero` (which we don't use so `is_zero` can return `Choice` and use `ConstantTimeEq` to compare values in constant-time). https://docs.rs/num-traits/latest/num_traits/identities/trait.Zero.html#method.set_zero
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to the
Zerotrait for setting its value to zero in-place, subsuming the previousBoxedUint::set_to_zerofunction.It's inspired by a similar method on
num_traits::Zero(which we don't use sois_zerocan returnChoiceand useConstantTimeEqto compare values in constant-time).https://docs.rs/num-traits/latest/num_traits/identities/trait.Zero.html#method.set_zero