Bring Checked* traits in line with Wrapping*
#434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate defines its own `Checked*` traits in order to use `CtOption<T>` rather than `Option<T>`, however it gets its `Wrapping*` traits from `num-bigint`. This brings the `Checked*` traits more in line with `Wrapping*`, automatically taking a reference to the `rhs` parameter, which eliminates the need to use HRTBs in `Integer`'s definition.
tarcieri
force-pushed
the
checked-trait-revamp
branch
from
9c9421d to
23f607e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate defines its own
Checked*traits in order to useCtOption<T>rather thanOption<T>, however it gets itsWrapping*traits fromnum-bigint.This brings the
Checked*traits more in line withWrapping*, automatically taking a reference to therhsparameter, which eliminates the need to use HRTBs inInteger's definition.