-
Notifications
You must be signed in to change notification settings - Fork 69
Move various operations on Words to a new primitves
module
#458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
95960ee
to
5fe3a4a
Compare
I guess this is draft because it's WIP? Otherwise looks great so far |
Adjusted the names and added some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good unless you wanted to add the Hacker's Delight overflow checks and such
If they're used elsewhere other than |
There is duplication between |
Not anymore. |
It seems like these two duplicate each other: https://github.com/RustCrypto/crypto-bigint/blob/00e1a60/src/const_choice.rs#L71-L85 And it's also duplicated here: https://github.com/RustCrypto/crypto-bigint/blob/00e1a60/src/modular/boxed_residue/mul.rs#L305 Potentially all three could call a common function? |
The one in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks great now
TODO: review function names