Skip to content

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Dec 20, 2023

Fixes #351

  • Residue -> ConstMontyForm
  • DynResidue -> MontyForm
  • BoxedResidue -> BoxedMontyForm
  • *ResidueParams -> *MontyParams
  • residue_params -> params
  • params.r -> params.one

Please don't open other PRs before this one is merged, it's a pain to rebase.

@fjarri fjarri marked this pull request as ready for review December 20, 2023 02:07
@tarcieri
Copy link
Member

Your description doesn't quite reflect the names, which are MontyForm instead of just Monty.

For the params names, I'd prefer MontyParams instead of MontyFormParams which seems needlessly long.

Otherwise yes, we should get this rename done ASAP.

@fjarri
Copy link
Contributor Author

fjarri commented Dec 20, 2023

Renamed

@tarcieri tarcieri merged commit 296bd55 into RustCrypto:master Dec 20, 2023
@tarcieri tarcieri mentioned this pull request Dec 20, 2023
@fjarri fjarri deleted the residue-rename branch December 20, 2023 18:07
@tarcieri tarcieri mentioned this pull request Jan 22, 2025
@Fethbita
Copy link

@tarcieri could you also add the rename const_residue -> const_monty_form into changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reopening *Residue naming bikeshed

3 participants