Uint: change split_mixed to accept self; make pub
#556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `split_mixed` method provides a `const fn`-friendly way to split numbers. This refactors it to be a method that accepts `self` as an argument so it can be called as `uint.split_mixed()` and also exposes it as `pub`, allowing downstream users to use it in `const fn` contexts. A newly added `SplitMixed` bound typechecks the sizes of the outputs to ensure that they're a valid combination, which is the best we can do absent something like `generic_const_exprs`.
tarcieri
added a commit
that referenced
this pull request
Jan 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
split_mixedmethod provides aconst fn-friendly way to split numbers.This refactors it to be a method that accepts
selfas an argument so it can be called asuint.split_mixed()and also exposes it aspub, allowing downstream users to use it inconst fncontexts.A newly added
SplitMixedbound typechecks the sizes of the outputs to ensure that they're a valid combination, which is the best we can do absent something likegeneric_const_exprs.