-
Notifications
You must be signed in to change notification settings - Fork 69
Add a RemMixed trait and impl for Uints #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks fine as a general direction |
What else would you like to see done here, can you give me a rough idea? |
@dvdplm if you think it's ready, can you remove draft? |
In f6caf92 I added an impl for As a rule, should all traits be impl'd for |
FWIW we don't impl other Re: trait parity for |
When the `RemMixed` trait was added in #746 I missed that we need an impl for even splits as well. This rectifies that mistake.
Add a
RemMixed
trait in the same vein asSplitMixed
andConcatMixed
, to calculate the remainder of differently sized integers.Fixes #739.