signature: remove Default bound on SignatureEncoding::Repr
#1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the `Default` impl on `core` array types is still
problematic here:
error[E0277]: the trait bound `[u8; 64]: Default` is not satisfied
--> ed25519/src/lib.rs:339:17
|
339 | type Repr = SignatureBytes;
| ^^^^^^^^^^^^^^ the trait `Default` is not implemented for `[u8; 64]`
tarcieri
added a commit
that referenced
this pull request
Oct 30, 2022
Without a `Default` bound (#1143) there's little purpose to having an `AsMut` bound on `Repr`, which would allow `Default` to construct an empty bytestring and `AsMut` used to write into it. Given there isn't an obvious use case, fewer bounds are better.
tarcieri
added a commit
that referenced
this pull request
Oct 30, 2022
Without a `Default` bound (#1143) there's little purpose to having an `AsMut` bound on `Repr`, which would allow `Default` to construct an empty bytestring and `AsMut` used to write into it. Given there isn't an obvious use case, fewer bounds are better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the
Defaultimpl oncorearray types is still problematic here: