Skip to content

Fix iOS, tvOS Deployment target & Travis CI build fail #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Fix iOS, tvOS Deployment target & Travis CI build fail #399

merged 2 commits into from
Aug 28, 2021

Conversation

ElonPark
Copy link
Member

@ElonPark ElonPark commented May 10, 2021

  • change iOS, tvOS Deployment target equal to SwiftPM, CocoaPods indicated version
- IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+ IPHONEOS_DEPLOYMENT_TARGET = 9.0;
- TVOS_DEPLOYMENT_TARGET = 12.0;
+ TVOS_DEPLOYMENT_TARGET = 9.0;
  • Also fix Travis CI build fail
    • carthage update --platform tvOS && carthage build --no-skip-current --platform tvOS

@iamszabo
Copy link
Member

Is there any reason this cannot be merged to master? @freak4pc

@Unknoob
Copy link

Unknoob commented Jul 20, 2021

Can we get this merged? Both versions 5.0.0 and 5.0.1 are broken on carthage and this PR would fix it.

@valerianb
Copy link

@freak4pc Hi, would very much appreciate if this could get merged and have a release with it. Thanks 😊

@freak4pc
Copy link
Member

Sorry, I haven't been looking into RxDataSources enough lately :)
It seems specifically the Carthage-related CI isn't building with this change. Could you fix it and I'll merge and cut a new release? Thanks.

https://travis-ci.org/github/RxSwiftCommunity/RxDataSources/jobs/770505930

@ElonPark @valerianb

@ElonPark
Copy link
Member Author

@freak4pc i'll check it

@ElonPark
Copy link
Member Author

Travis CI build fail is side effect of #392

@ElonPark ElonPark changed the title Fix iOS, tvOS Deployment target Fix iOS, tvOS Deployment target & Travis CI build fail Aug 28, 2021
@freak4pc freak4pc merged commit 90c29b4 into RxSwiftCommunity:main Aug 28, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @ElonPark! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ElonPark ElonPark self-assigned this Aug 28, 2021
@ElonPark ElonPark requested a review from freak4pc August 28, 2021 11:24
@ElonPark ElonPark added the bug label Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Carthage] IPHONEOS_DEPLOYMENT_TARGET on Xcode project does not match the SPM target.
5 participants