Skip to content

Add shadcn recipe to docs #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add shadcn recipe to docs #372

wants to merge 4 commits into from

Conversation

arpxspace
Copy link
Contributor

No description provided.

@jwthomson
Copy link
Contributor

In the Github preview the numbering keeps restarting, I think because the indentation is not quite right. Have you / could you please check to see if this is happening in your local docs instance?

image

@arpxspace
Copy link
Contributor Author

ah bugger. will have a look, cheers.

@jwthomson
Copy link
Contributor

jwthomson commented May 9, 2025

I ran through the process from start to end and it nearly worked 😉

Missing steps:

  1. Fix the npm ci command as per your PR: move package.json and package-lock.json to /src/Client SAFE-template#658
  2. Set up for a resolve config in the vite config, which when missing, gives package resolution errors.

But other than those, and the comments I left (which are minor), I think the instructions are solid and easy to follow - and of course they work! Thanks Amir 😄

@arpxspace
Copy link
Contributor Author

arpxspace commented May 12, 2025

once SAFE-Stack/SAFE-template#658 has been approved:

  • remove #### 2. Move package.json & package-lock.json to /src/Client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants