Skip to content

Update ENHS Type #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 22, 2021
Merged

Update ENHS Type #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
809304b
ENHS Type
wurzka Jul 20, 2021
ff8a9e8
Add example enhs
wurzka Jul 20, 2021
7c72f59
Reaction to abaplint
wurzka Jul 20, 2021
cd59b35
Remove Example
wurzka Jul 20, 2021
38120f2
Abaplint
wurzka Jul 20, 2021
ecced5f
Typo
wurzka Jul 20, 2021
7efdc6a
New Header
wurzka Jul 20, 2021
3c46e21
Remove $values link
wurzka Jul 20, 2021
e6f6836
Change title/description of Example Class
wurzka Jul 20, 2021
8bd6020
abaplint
wurzka Jul 20, 2021
2b31366
Show always multipleUse
wurzka Jul 20, 2021
fda2a6b
Add example ENHS
wurzka Jul 20, 2021
01e9cf6
Delete tag use_fallback_class
wurzka Jul 21, 2021
8bf877d
Description of fallback_class
wurzka Jul 21, 2021
13e302f
Merge branch 'main' into feature/enhs_v1
wurzka Jul 21, 2021
60e42ae
Merge branch 'main' into feature/enhs_v1
wurzka Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 40 additions & 50 deletions file-formats/enhs/enhs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "http://github.com/SAP/abap-file-formats/file-formats/enhs/enhs.json",
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/enhs/enhs.json",
"title": "ENHS Object Type",
"description": "Object type ENHS",
"type": "object",
"properties": {
"$schema": {
Expand All @@ -10,23 +12,23 @@
},
"header": {
"title": "Header",
"description": "Header",
"type": "object",
"properties": {
"description": {
"title": "Description",
"description": "Description of an BAdI Enhancement Spot",
"description": "Description of the ABAP object",
"type": "string",
"maxLength": 255
"maxLength": 100
},
"masterLanguage": {
"title": "Master Language",
"description": "Master language of the BAdI Enhancement Spot\nAll translatable text shall be maintained in this language",
"originalLanguage": {
"title": "Original Language",
"description": "Original language of the ABAP object",
"type": "string",
"minLength": 2,
"maxLength": 2
},
"abapLanguageVersion": {
"title": "Abap Language Version",
"title": "ABAP Language Version",
"description": "ABAP language version",
"type": "string",
"enum": [
Expand All @@ -36,15 +38,15 @@
],
"enumDescriptions": [
"Standard",
"ABAP for key user tools",
"ABAP for Cloud Development"
"ABAP for key user extensibility",
"ABAP cloud development"
]
}
},
"additionalProperties": false,
"required": [
"description",
"masterLanguage",
"originalLanguage",
"abapLanguageVersion"
]
},
Expand All @@ -66,7 +68,7 @@
"badiDefinition"
],
"enumDescriptions": [
"BAdI Definition"
"BAdI definition"
]
}
},
Expand Down Expand Up @@ -118,7 +120,7 @@
]
},
"multipleUse": {
"title": "Single- or multiple use BAdI",
"title": "Single- or Multiple Use BAdI",
"description": "Indicator whether the BAdI definition is single- or multiple usable",
"type": "boolean"
},
Expand All @@ -138,27 +140,22 @@
"maxLength": 30
}
},
"useFallbackClass": {
"title": "Use Fallback Class",
"description": "Use fallback class in case no implementation is executed",
"type": "boolean"
},
"fallbackClass": {
"title": "Name of the Default/Fallback Class",
"description": "Name of the default/fallback class",
"description": "Name of the default/fallback class. The fallback class is executed if no BAdI implementation exists.",
"type": "string",
"maxLength": 30
},
"filterLimitation": {
"title": "Limited Filter use",
"title": "Limited Filter Use",
"description": "Limited filter use",
"type": "boolean"
},
"documentationId": {
"title": "Documentation Id",
"description": "Documentation Id",
"type": "string",
"maxLength": 30
"maxLength": 60
},
"amdp": {
"title": "Amdp BAdI",
Expand All @@ -171,18 +168,18 @@
"type": "array",
"items": {
"title": "Filter",
"description": "Information about this Filter",
"description": "Information about this filter",
"type": "object",
"properties": {
"name": {
"title": "Name of the Filter",
"description": "Name of the Filter",
"description": "Name of the filter",
"type": "string",
"maxLength": 30
},
"description": {
"title": "Description of the Filter",
"description": "Description of the Filter",
"description": "Description of the filter",
"type": "string",
"maxLength": 255
},
Expand All @@ -191,15 +188,15 @@
"description": "Type of the filter",
"type": "string",
"enum": [
"Integer",
"Character",
"String",
"Numeric",
"Packed"
"integer",
"characterLike",
"string",
"numeric",
"packed"
],
"enumDescriptions": [
"Integer",
"Character",
"Character-like",
"String",
"Numeric",
"Packed"
Expand All @@ -212,26 +209,27 @@
},
"valueCheckDdic": {
"title": "Value Check Ddic",
"description": "Value check via Domain or Data Element",
"description": "Value check via domain or data element",
"type": "object",
"properties": {
"type": {
"title": "Type of the Value Check Object",
"description": "Type of the value check object",
"type": "string",
"enum": [
"Domain",
"DataElement"
"domain",
"dataElement"
],
"enumDescriptions": [
"Domain",
"Data Element"
"Data element"
]
},
"objectName": {
"title": "Name of the Value Check Object",
"description": "Name of the value check object",
"type": "string"
"type": "string",
"maxLength": 30
}
},
"additionalProperties": false,
Expand All @@ -249,17 +247,21 @@
"title": "Name of the Value Check Class",
"description": "Name of the value check class",
"type": "string",
"maxLenght": 30
"maxLength": 30
},
"length": {
"title": "Length of the Value Check",
"description": "Length of the value check",
"type": "number"
"type": "integer",
"minimum": -2147483648,
"maximum": 2147483647
},
"decimalPlaces": {
"title": "Decimal Places of the Value Check",
"description": "Decimal places of the value check",
"type": "number"
"type": "integer",
"minimum": -2147483648,
"maximum": 2147483647
}
},
"additionalProperties": false,
Expand All @@ -277,18 +279,6 @@
}
}
},
"if": {
"properties": {
"useFallbackClass": {
"const": "true"
}
}
},
"then": {
"required": [
"fallbackClass"
]
},
"additionalProperties": false,
"required": [
"name",
Expand Down
10 changes: 3 additions & 7 deletions file-formats/enhs/examples/z_aff_example_enhs.enhs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/SAP/abap-file-formats/main/file-formats/enhs/enhs.json",
"$schema": "http://github.com/sap/abap-file-formats/blob/main/file-formats/enhs/enhs.json",
"header": {
"description": "Example ENHS for ABAP file formats",
"masterLanguage": "EN",
"originalLanguage": "EN",
"abapLanguageVersion": "standard"
},
"configuration": {
Expand All @@ -15,15 +15,11 @@
"interface": "Z_AFF_EXAMPLE_BADI_INTF",
"instantiation": "creatingNewInstances",
"multipleUse": true,
"useFallbackClass": false,
"filterLimitation": false,
"documentationId": "",
"amdp": false,
"filters": [
{
"name": "EXAMPLE_FILTER",
"description": "This is an example Filter",
"type": "String"
"type": "string"
}
]
}
Expand Down
Loading