-
Notifications
You must be signed in to change notification settings - Fork 68
Change originalLanguage to ISO639-1 standard #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes #34 |
suggest adding a regular expression in the schema validation, to check its lower case(are numbers allowed?) |
I can check whether I can add a |
Each language field shall consist of 2 lower-case letters.
I have added the following attributes for language fields
|
BTW - I have also fixed the pattern for numerics. It was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the json.md file, there is an example with a language. There, the minLength and pattern has to be added, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you missed my comment about the json.md file above. Can you add the additional fields in the example json schema there?
@wurzka Yes, sorry. I missed your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM :)
mirror changes made in SAP/abap-file-formats#279
No description provided.