[SXTG] Add new object type SXTG #687
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # SXTG File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.sxtg.json` | 1 | [`zif_aff_sxtg_v1.intf.abap`](./type/zif_aff_sxtg_v1.intf.abap) | [`sxtg-v1.json`](./sxtg-v1.json) | [`sxtg_tsm_so.sxtg.json`](./examples/sxtg_tsm_so.sxtg.json) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "SXTG: Sales Order Header (Home)", | ||
| "originalLanguage": "en" | ||
| }, | ||
| "generalInformation": { | ||
| "extensionInclude": "SXTG_S_TSM_SO_INCL_EEW", | ||
| "applicationDataStructure": "SXTG_S_TSM_SO_APPL_DATA", | ||
| "uiExtensionEntity": "D_SXTG_TSM_SO_UI_HEADER" | ||
| }, | ||
| "transactionCodes": [ | ||
| { | ||
| "transactionCode": "SXTG_TSM_SO" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/sxtg/sxtg-v1.json", | ||
| "title": "SAP GUI Extension Point", | ||
| "description": "SAP gui extension point for developer extensibility", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "Format Version", | ||
| "description": "Format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "Description of the ABAP object", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the ABAP object", | ||
| "type": "string", | ||
| "minLength": 2 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "generalInformation": { | ||
| "title": "General Information", | ||
| "description": "General information", | ||
| "type": "object", | ||
| "properties": { | ||
| "extensionInclude": { | ||
| "title": "Extension Include", | ||
| "description": "Extension include with persisted custom fields", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "applicationDataStructure": { | ||
| "title": "Application Data Structure", | ||
| "description": "Structure with application data", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "uiExtensionEntity": { | ||
| "title": "UI Extension Entity", | ||
| "description": "Abstract entity with ui definition", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "extensionInclude", | ||
| "applicationDataStructure", | ||
| "uiExtensionEntity" | ||
| ] | ||
| }, | ||
| "transactionCodes": { | ||
| "title": "Transaction Codes", | ||
| "description": "Transaction codes of extensible application", | ||
| "type": "array", | ||
| "items": { | ||
| "title": "Transaction Code", | ||
| "description": "Transaction code", | ||
| "type": "object", | ||
| "properties": { | ||
| "transactionCode": { | ||
| "title": "Transaction Code", | ||
| "description": "Transaction code", | ||
| "type": "string", | ||
| "maxLength": 20 | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,59 @@ | ||||||
| INTERFACE zif_aff_sxtg_v1 | ||||||
| PUBLIC. | ||||||
|
|
||||||
| TYPES: | ||||||
| "! <p class="shorttext">Transaction Code</p> | ||||||
| "! Transaction code | ||||||
| BEGIN OF ty_transaction_code, | ||||||
| "! <p class="shorttext">Transaction Code</p> | ||||||
| "! Transaction code | ||||||
| transaction_code TYPE c LENGTH 20, | ||||||
| END OF ty_transaction_code. | ||||||
|
|
||||||
| "! <p class="shorttext">Transaction Codes</p> | ||||||
| "! Transaction codes | ||||||
| TYPES ty_transaction_codes TYPE STANDARD TABLE OF ty_transaction_code WITH KEY transaction_code. | ||||||
|
|
||||||
| TYPES: | ||||||
| "! <p class="shorttext">General Information</p> | ||||||
| "! General information | ||||||
| BEGIN OF ty_general_information, | ||||||
| "! <p class="shorttext">Extension Include</p> | ||||||
| "! Extension include with persisted custom fields | ||||||
| "! $required | ||||||
| extension_include TYPE zif_aff_types_v1=>ty_object_name_30, | ||||||
|
|
||||||
| "! <p class="shorttext">Application Data Structure</p> | ||||||
| "! Structure with application data | ||||||
| "! $required | ||||||
| application_data_structure TYPE zif_aff_types_v1=>ty_object_name_30, | ||||||
|
|
||||||
| "! <p class="shorttext">UI Extension Entity</p> | ||||||
| "! Abstract entity with ui definition | ||||||
| "! $required | ||||||
| ui_extension_entity TYPE zif_aff_types_v1=>ty_object_name_30, | ||||||
| END OF ty_general_information. | ||||||
|
|
||||||
| TYPES: | ||||||
| "! <p class="shorttext">SAP GUI Extension Point</p> | ||||||
| "! SAP gui extension point for developer extensibility | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| BEGIN OF ty_main, | ||||||
| "! <p class="shorttext">Format Version</p> | ||||||
| "! Format version | ||||||
| "! $required | ||||||
| format_version TYPE zif_aff_types_v1=>ty_format_version, | ||||||
| "! <p class="shorttext">Header</p> | ||||||
| "! Header | ||||||
| "! $required | ||||||
| header TYPE zif_aff_types_v1=>ty_header_60_no_abap_lv, | ||||||
|
|
||||||
| "! <p class="shorttext">General Information</p> | ||||||
| "! General information | ||||||
| general_information TYPE ty_general_information, | ||||||
|
|
||||||
| "! <p class="shorttext">Transaction Codes</p> | ||||||
| "! Transaction codes of extensible application | ||||||
| transaction_codes TYPE ty_transaction_codes, | ||||||
| END OF ty_main. | ||||||
|
|
||||||
| ENDINTERFACE. | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "SXTG: SAP GUI Extension Point AFF Type", | ||
| "originalLanguage": "en" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: In other object types we did not repeated the array name in the structure and changed it the field for the object name just to
name. However, I would suggest to double check this in the UX review.This suggestion shall show how it could look like. I would wait whether our UX colleagues suggest to change it: