feat: [Orchestration] Unit test embeddings and client refactoring #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanackal
changed the title
rpanackal
changed the base branch from
main
to
spec-update/orchestration/fix/streaming-response-type
newtork
reviewed
Jun 18, 2025
| } | ||
|
|
||
| return executeRequest(jsonRequest); | ||
| return executor.execute("/completion", request, CompletionPostResponseSynchronous.class); |
There was a problem hiding this comment.
(Minor)
static constant for /completion
newtork
reviewed
Jun 18, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java
Show resolved
Hide resolved
newtork
reviewed
Jun 18, 2025
Comment on lines
+31
to
+34
| OrchestrationHttpExecutor(@Nonnull final Supplier<HttpDestination> destinationSupplier) | ||
| throws OrchestrationClientException { | ||
| this.destinationSupplier = destinationSupplier; | ||
| } |
There was a problem hiding this comment.
(Question)
Why no lombok constructor? :)
newtork
reviewed
Jun 18, 2025
| responseType, OrchestrationError.class, OrchestrationClientException::new) | ||
| .objectMapper(JACKSON); | ||
| return client.execute(request, handler); | ||
|
|
newtork
reviewed
Jun 18, 2025
| .objectMapper(JACKSON); | ||
| return client.execute(request, handler); | ||
|
|
||
| } catch (JsonProcessingException e) { |
There was a problem hiding this comment.
(Question)
Don't these need final?
newtork
reviewed
Jun 18, 2025
| @Nonnull | ||
| Stream<OrchestrationChatCompletionDelta> stream(@Nonnull final Object payload) { | ||
| try { | ||
|
|
newtork
reviewed
Jun 18, 2025
| OrchestrationClientException::new) | ||
| .objectMapper(JACKSON) | ||
| .handleStreamingResponse(client.executeOpen(null, request, null)); | ||
|
|
newtork
approved these changes
Jun 18, 2025
|
Let's merge, we need to get it done. |
newtork
merged commit e62952d
into
spec-update/orchestration/fix/streaming-response-type
8 of 9 checks passed
newtork
added a commit
that referenced
this pull request
Jul 9, 2025
* Update orchestration based on fix/streaming-response-type * WiP * Latest spec with error classes * regenerate * regenerate * DPI * feat: Add embeddings endpoint and refactor orchestration client (#464) Co-authored-by: Roshin Rajan Panackal <[email protected]> * fix: [Orchestration] Spec update - Filtering, Remove "Synchronous" suffix and Embedding property renaming (#469) * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Release notes and jacoco coverage work around * Lower min required jacoco coverage complexity and branch rating. - Release note paraphrasing * Update e2e for input filters --------- Co-authored-by: Roshin Rajan Panackal <[email protected]> * Make embedding client endpoint non-visible and update javadoc (minor) * merge main * Formatting * 0.81.4 --------- Co-authored-by: SAP Cloud SDK Bot <[email protected]> Co-authored-by: Roshin Rajan Panackal <[email protected]> Co-authored-by: Roshin Rajan Panackal <[email protected]> Co-authored-by: Alexander Dümont <[email protected]>
newtork
added a commit
that referenced
this pull request
Aug 7, 2025
* Update orchestration based on fix/streaming-response-type * WiP * Latest spec with error classes * regenerate * regenerate * DPI * feat: Add embeddings endpoint and refactor orchestration client (#464) Co-authored-by: Roshin Rajan Panackal <[email protected]> * fix: [Orchestration] Spec update - Filtering, Remove "Synchronous" suffix and Embedding property renaming (#469) * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Release notes and jacoco coverage work around * Lower min required jacoco coverage complexity and branch rating. - Release note paraphrasing * Update e2e for input filters --------- Co-authored-by: Roshin Rajan Panackal <[email protected]> * Make embedding client endpoint non-visible and update javadoc (minor) * Integrate v2 spec changes - `ConfigToRequestTransformer` (not fixed) * merge main * `ConfigToRequestTransformer` ready and adapt some tests (minimal) * Formatting * Partial migration of payload to v2 * All json updated * refactor (minor) and renaming * jacoco min threshold lowered * Formatting * Fix e2e test issue * Fix merge error * Formatting * update release notes * partial merge fix * Fix tests and add new mixin for filtering response * Include ErrorResponseStreaming * Update unit testing stream completion * better javadoc and getVersion fix -> getModelVersion * Minor syntax improvement * change from abstract class to interface * Fix message * Add comment --------- Co-authored-by: SAP Cloud SDK Bot <[email protected]> Co-authored-by: I538344 <[email protected]> Co-authored-by: Roshin Rajan Panackal <[email protected]> Co-authored-by: Alexander Dümont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#270.
Prerequisite:
A new endpoint for embedding
/v2/embeddingsis being added with Orchestration release 6a. This PR contains related model classes and refactored client class to minimize code duplication.Note: This PR also contains changes from other spec update.
Feature scope:
OrchestrationHttpExecutor(non public) introduced to generalize execution of http calls.Definition of Done
Aligned changes with the JavaScript SDK