feat: [OpenAI] Sample code for Agentic Workflow tutorial #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanackal
reviewed
Jul 3, 2025
| for (final String systemPrompt : systemPrompts) { | ||
|
|
||
| // Combine the pre-defined prompt with the previous answer to get the new input | ||
| val input = String.format("{%s}\n {%s}", systemPrompt, responseText); |
There was a problem hiding this comment.
(Preference)
Looks like here we are mixing system prompt with user prompt, which should not be encouraged. I am assuming this is a simplification for the sake of demonstration. But, I would prefer if we distinguish the usage of user and system message correctly.
That said, SpringAi docs also seems to simply concatenate the messages, which is sus to me. Let me know if I missed something.
There was a problem hiding this comment.
I would agree with you initially. But then I realized "responseText" reference is updated with the LLM response from previous step in line 71. Meaning there is no classic distinction user/system/assistant, they get mixed when the second iteration starts.
newtork
previously approved these changes
Aug 7, 2025
newtork
previously approved these changes
Aug 7, 2025
newtork
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#266
This PR adds sample code for the Java agentic workflow tutorial (link to docs PR is below).
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveRelease notes updated