Skip to content

Conversation

n-o-u-r-h-a-n
Copy link
Contributor

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Aug 13, 2025

Context

AI/ai-sdk-java-backlog#179.

Implementation of Streaming for OpenAi in SpringAi was required to complete implementation of streamChatCompletion.

Feature scope:

  • Updating OpenAiChatModel Class.
  • Updating SpringAiOpenAiController Class.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

Jonas-Isr and others added 30 commits June 16, 2025 17:44
…AiService + their corresponding passed tests in SpringAiOpenAiTest class.

Regarding the OpenAiChatModel class it was just formatting, nothing changed.
--> 4 methods in OpenAiChatCompletionRequest.java return only this now and other constructors other than main are removed for now.
…ringopenai

# Conflicts:
#	core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java
@CharlesDuboisSAP CharlesDuboisSAP changed the title feat: Implementing Streaming for OpenAi in SpringAi feat: SpringAI integration in OpenAI Aug 14, 2025
@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Aug 14, 2025
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes mentioning the new public API are lacking.

@n-o-u-r-h-a-n n-o-u-r-h-a-n merged commit 9605b66 into main Aug 19, 2025
7 checks passed
@n-o-u-r-h-a-n n-o-u-r-h-a-n deleted the chatcompletion-for-springopenai2 branch August 19, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants