chore: [Orchestration] Removing schema and template from sample code #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-o-u-r-h-a-n
changed the title
n-o-u-r-h-a-n
changed the title
...-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
Show resolved
Hide resolved
CharlesDuboisSAP
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customized Template variable which was created to configure orchestration options was removed in SpringAiOrchestrationService class.
Context
AI/ai-sdk-java-backlog#315.
There was a duplication in functionality , so these lines were removed.
Regarding the task's bug, there was neither a way found to turn off the implicit Spring AI Logic nor to customize it to set the TemplateConfig automatically as ChatClient is only accessible from the sample code not from the implementation side of the Orchestration Service.
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKRelease notes updated