Skip to content

Unit test WITHOUT_ISSUE in Y_CHECK_COMMENT_USAGE fails #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ConjuringCoffee opened this issue Nov 10, 2021 · 0 comments · Fixed by #533 or #529
Closed

Unit test WITHOUT_ISSUE in Y_CHECK_COMMENT_USAGE fails #527

ConjuringCoffee opened this issue Nov 10, 2021 · 0 comments · Fixed by #533 or #529
Assignees
@lucasborin
Labels
bug Something isn't working correctly

Comments

@ConjuringCoffee
Copy link
Contributor

ConjuringCoffee commented Nov 10, 2021 •
edited
Loading

The unit test method WITHOUT_ISSUE of class Y_CHECK_COMMENT_USAGE (inherited from Y_UNIT_TEST_BASE) fails. It finds an issue in source code that shouldn't have an issue.

Here's the failure trace:

Critical Assertion Error: 'Syntax Error'
Details
Message:Type "SUT_SETTINGS" is unknown., Line:4, Word:SUT_SETTINGS-NAME
Test 'LTC_PRAGMA->WITHOUT_ISSUE' in Main Program 'Y_CHECK_COMMENT_USAGE=========CP'.
Stack
Include: <Y_CODE_PAL_REF_SCAN_DOUBLE====CM008> Line: <13> (SYNTAX_CHECK)
Include: <Y_CODE_PAL_REF_SCAN_DOUBLE====CM001> Line: <2> (CONVERT_CODE)
Include: <Y_CODE_PAL_REF_SCAN_DOUBLE====CM003> Line: <2> (GET)
Include: <Y_UNIT_TEST_BASE==============CM004> Line: <2> (GIVEN_CODE_WITHOUT_ISSUE)
Include: <Y_UNIT_TEST_BASE==============CM00E> Line: <3> (WITHOUT_ISSUE)

I'm running the tests of commit c782c26 on an S/4 system with component SAP_BASIS release 755 SP-Level 0002. Can anyone confirm if the test runs successfully on older releases?

Please note that this isn't the only unit test that fails in my system: #525 and #526
The issues might be connected.
@ConjuringCoffee ConjuringCoffee added the bug Something isn't working correctly label Nov 10, 2021
@lucasborin lucasborin self-assigned this Nov 11, 2021
lucasborin pushed a commit that referenced this issue Nov 11, 2021
fixing #527
1e94b1e
lucasborin added a commit that referenced this issue Nov 11, 2021
@lucasborin
SUT Dependency (#533)
6c8666c 
* forcing cspell to track sut dependencies

* changelog

* fixing #527

Co-authored-by: Lucas Borin <[email protected]>
This was linked to pull requests Nov 11, 2021
SUT Dependency #533
Merged
1.16.3 #529
Merged
lucasborin added a commit that referenced this issue Nov 11, 2021
@lucasborin
1.16.3 (#529)
4f6936f 
* updating changelog

* new version

* Removing Service (#530)

* solves #524

* changelog

* removing it from the documentation

Co-authored-by: Lucas Borin <[email protected]>

* Refactoring Function Check (#531)

* fixes #526

* changelog

* Start statement at tab position

Co-authored-by: Lucas Borin <[email protected]>

* SUT Dependency (#533)

* forcing cspell to track sut dependencies

* changelog

* fixing #527

Co-authored-by: Lucas Borin <[email protected]>

* changelog

Co-authored-by: Lucas Borin <[email protected]>
ghost pushed a commit that referenced this issue Feb 18, 2022
@lucasborin @abaplint
1.16.3 - rollback (#551)
04414f2 
* updating changelog

* new version

* Removing Service (#530)

* solves #524

* changelog

* removing it from the documentation

Co-authored-by: Lucas Borin <[email protected]>

* Refactoring Function Check (#531)

* fixes #526

* changelog

* Start statement at tab position

Co-authored-by: Lucas Borin <[email protected]>

* SUT Dependency (#533)

* forcing cspell to track sut dependencies

* changelog

* fixing #527

Co-authored-by: Lucas Borin <[email protected]>

* changelog

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update y_check_function.clas.abap

* Update y_check_function.clas.abap

* Update src/checks/y_check_function.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_function.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update y_check_function.clas.abap

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasborin lucasborin

Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SUT Dependency SAP/code-pal-for-abap
1.16.3 SAP/code-pal-for-abap
2 participants
@lucasborin @ConjuringCoffee