Skip to content

Conversation

MariaIDineva
Copy link
Contributor

@MariaIDineva MariaIDineva commented Sep 16, 2025

Related Issue(s)

closes #12584

Description

Makes List group item focusable so that it is read by screen readers.

  • Add fd-list-item attribute to fd-list-group-header to make the header focusable. Adds role='group' to the element.

  • Adds the following aria attributes to the group header to improve description so that readers read groups correctly (have followed the pattern used in UI5 as advised by a design accessibility expert): aria-roledescription, aria-label, aria-owns.

  • Adds an id-with-group-index attribute to list items to allow calculation of aria-owns for the header.

  • Adds aria-setsize, aria-posinset to appoint which list item belongs to which group.

  • Move tabindex from fd-list-group-header and fd-list-item to fd-list to avoid JAWS trapping focus on the first item and blocking up and down arrows.

Components affected:

  • Combobox with groups
  • Multi Combobox with groups

Screenshots

@MariaIDineva MariaIDineva self-assigned this Sep 16, 2025
@MariaIDineva MariaIDineva added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Sep 16, 2025
@MariaIDineva MariaIDineva changed the title fix(core): Multi Combobox group item not read fix(core):List group item not read Sep 16, 2025
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 569c94f
🔍 Latest deploy log https://app.netlify.com/projects/fundamental-ngx/deploys/68e678f5538e81000960f599
😎 Deploy Preview https://deploy-preview-13494--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MariaIDineva MariaIDineva changed the title fix(core):List group item not read fix(core): List: Group label not read Sep 16, 2025
@InnaAtanasova InnaAtanasova requested a review from a team September 16, 2025 16:29
@MariaIDineva MariaIDineva requested a review from a team October 6, 2025 08:20
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments above

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to mark as request changes

@MariaIDineva MariaIDineva merged commit ba5768c into main Oct 9, 2025
12 checks passed
@MariaIDineva MariaIDineva deleted the fix/multi-combobox-group-label-not-read branch October 9, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility: ACC-264.1] List: Group label not read.

4 participants