-
Notifications
You must be signed in to change notification settings - Fork 135
fix(core): List: Group label not read #13494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+229
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to screen readers
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… need to extend ListFocusItem
…s, not to group headers
InnaAtanasova
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments above
mikerodonnell89
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meant to mark as request changes
mikerodonnell89
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
use this label for any issue or enhancement related to screenreader/keyboard/etc support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #12584
Description
Makes List
group
itemfocusable
so that it is read by screen readers.Add
fd-list-item
attribute tofd-list-group-header
to make the header focusable. Addsrole='group'
to the element.Adds the following aria attributes to the group header to improve description so that readers read groups correctly (have followed the pattern used in UI5 as advised by a design accessibility expert):
aria-roledescription
,aria-label
,aria-owns
.Adds an
id-with-group-index
attribute to list items to allow calculation ofaria-owns
for the header.Adds
aria-setsize
,aria-posinset
to appoint which list item belongs to which group.Move
tabindex
fromfd-list-group-header
andfd-list-item
tofd-list
to avoid JAWS trapping focus on the first item and blocking up and down arrows.Components affected:
Screenshots