feat: add onSelect callback to ComboboxInput;Select;SearchInput #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skvale
commented
Apr 3, 2020
| > | ||
| <div | ||
| className="fd-select__control" | ||
| className="fd-select__control is-success" |
There was a problem hiding this comment.
This snapshot is changed because the previous test misspelled validationState as uvalidationState
|
Deploy preview for fundamental-react ready! Built with commit ef852fa |
Add punctuation
skvale
changed the title
|
Hi team, I just wonder how can we retrieve the value that we have selected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an onSelect callback event for
ComboboxInput,Select, andSearchInputand reflect the changes in theComboboxInputandSelectcomponents.[BREAKING]
listprop, instead, it takes an options array of shape{key, text}{key, text}fixes #921