fix: city filter #116
Merged
fix: city filter #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelioDantas
pushed a commit
to HelioDantas/backend
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que?
Removido as cidades nulas da lista de cidades retornada pelo endpoint GET shelter/cities.
Por que?
As cidades estavam vindo com o nome default de "Cidade não informada" quando ela possuia com campo city NULO no banco de dados. E esse comportamento estava fazendo aparecer no select do frontend inúmeras "cidade não informada". Quando usado uma cidade cujo nome era "Cidade não informada" no filtro e buscado na api, nao era retornado nenhum resultado, sendo que o comportamento esperado era não buscar por cidade específica já que a cidade não foi informada.
Como?
Adicionado uma clausula Where no filtro de cidades onde ele busca apenas os registros que possuem a coluna city como NOT NULL.