Skip to content

Conversation

BertBR
Copy link
Contributor

@BertBR BertBR commented May 20, 2024

  • Melhora a cobertura de testes para a entidade Partner

@rodrigooler rodrigooler added the enhancement New feature or request label May 20, 2024
Copy link
Contributor

@rodrigooler rodrigooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BertBR, você poderia adicionar alguns casos de uso com dados mockados para verificar o retorno e a validação? Também seria útil incluir cenários em que o código de criação possa falhar e retornar os erros esperados.

@BertBR BertBR requested a review from rodrigooler May 20, 2024 23:32
@BertBR BertBR requested a review from giggio May 21, 2024 02:36
@BertBR
Copy link
Contributor Author

BertBR commented May 22, 2024

PR fechada pelo mesmo motivo dessa outra: #159

@BertBR BertBR closed this May 22, 2024
@giggio giggio reopened this May 23, 2024
@giggio
Copy link
Member

giggio commented May 23, 2024

@BertBR eu gostaria de integrar isso aí, vou revisar suas alterações.

Copy link
Member

@giggio giggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agora está ok, bora integrar.

@giggio giggio merged commit bc100dd into SOS-RS:develop May 23, 2024
@BertBR BertBR deleted the test/partners branch May 23, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Entregue (Po + Dev + Infra)

Development

Successfully merging this pull request may close these issues.

3 participants