ability to compare a bean or map or collection by the result of a method call

[j1ee]

this allows us to configure if we want to compare a collection by the result of size() or if we want to call a specific getter on a bean.

[SQiShER]

isWithMethodEquals sounds a little strange. How about hasAlternativeEqualsMethod?

[j1ee]

It is checking equality of the result of the method, so
"isWithMethodResultEqual" is more explicit, if a little verbose.
Your call, I suppose!
On 25 Jul 2013 21:10, "Daniel Bechler" [email protected] wrote:

In src/main/java/de/danielbechler/diff/CollectionDiffer.java:

@@ -61,6 +61,17 @@ else if (nodeInspector.isEqualsOnly(collectionNode))
collectionNode.setState(Node.State.CHANGED);
}
}

•   else if (nodeInspector.isWithMethodEquals(collectionNode)){
  

isWithMethodEquals sounds a little strange. How about
hasAlternativeEqualsMethod?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69/files#r5408527
.

[SQiShER]

Ah, yes, now I see. I'm still not sold on isWithMethodResultEqual though. Even with the context I had, I failed to see what it does by just reading the name. But I think we should rather look for a better name in the Configuration, as it will dictate the names in the remaining places.

[j1ee]

I agree.
How about "isComparedByMethodResult"?
I think this is a little clearer. I will let you know if I think of
something better!
On 25 Jul 2013 21:38, "Daniel Bechler" [email protected] wrote:

In src/main/java/de/danielbechler/diff/CollectionDiffer.java:

@@ -61,6 +61,17 @@ else if (nodeInspector.isEqualsOnly(collectionNode))
collectionNode.setState(Node.State.CHANGED);
}
}

•   else if (nodeInspector.isWithMethodEquals(collectionNode)){
  

Ah, yes, now I see. I'm still not sold on isWithMethodResultEqual though.
Even with the context I had, I failed to see what it does by just reading
the name. But I think we should rather look for a better name in the
Configuration, as it will dictate the names in the remaining places.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69/files#r5409210
.

[SQiShER]

Much better, but still not as descriptive, as I'd like. How about hasEqualsOnlyValueProviderMethod, given we're using equalsOnlyValueProviderMethod in the Configuration?

[j1ee]

Yea cool, is more specific. Gotta stay consistent too. Sounds good.
On 25 Jul 2013 21:56, "Daniel Bechler" [email protected] wrote:

In src/main/java/de/danielbechler/diff/CollectionDiffer.java:

@@ -61,6 +61,17 @@ else if (nodeInspector.isEqualsOnly(collectionNode))
collectionNode.setState(Node.State.CHANGED);
}
}

•   else if (nodeInspector.isWithMethodEquals(collectionNode)){
  

Much better, but still not as descriptive, as I'd like. How about
hasEqualsOnlyValueProviderMethod, given we're using
equalsOnlyValueProviderMethod in the Configuration?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69/files#r5409765
.

[SQiShER]

I like what I see! The only thing I have mixed feelings about is the name "methodEqual". It doesn't really express what it really is: a method returning an object that is used for an equals only check instead of the original object. But that's hard to put in a short name. I'd like to see equalsOnly in there, as that's a term already known from the configuration. It's not pretty, but what do you think of equalsOnlyValueProviderMethod?

[SQiShER]

Great job! Much appreciated! I'll try to release a new version with your changes sometime this week.

[SQiShER]

Github doesn't seem to recognize the email address you used for your commits. If you'd like to appear in the list of contributors, you should be able to add it somewhere in your accounts Settings.

[j1ee]

I realised after. apparently github matches it up based on the email in
the commit itself (which I did not have configured).

It's fine though, don't worry about it.

On 29 July 2013 09:58, Daniel Bechler [email protected] wrote:

Github doesn't seem to recognize the email address you used for your
commits. If you'd like to appear in the list of contributors, you should be
able to add it somewhere in your accounts Settings.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-21707060
.

[SQiShER]

I think you can even add it afterwards.

On 29.07.2013, at 11:15, j1ee [email protected] wrote:

I realised after. apparently github matches it up based on the email in
the commit itself (which I did not have configured).

It's fine though, don't worry about it.

On 29 July 2013 09:58, Daniel Bechler [email protected] wrote:

Github doesn't seem to recognize the email address you used for your
commits. If you'd like to appear in the list of contributors, you should be
able to add it somewhere in your accounts Settings.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-21707060
.

—
Reply to this email directly or view it on GitHub.