Fix typo in breadcrumb_classes setting #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Risk is that a page template is checking using an if/then statement using the existing value and it would not recognize the new value. We would need to make sure to support backwards compatibility on this, so probably not merging right now. |
|
Because of our hosting ecosystem which does automatic theme updates, we have to have a backwards compatible solution. :/ Tabled for a potential future release.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request will sanitize the option value accepted by the theme setting breadcrumb_classes by removing the trailing space.
I know this is not backwards compatibly, but please think about adjusting your last change to a more sane option-value. Maybe one could run a migration on updating the theme, but I am not that much into maintaining Drupal Modules. If you can lead the way, I am happy to integrate a simple migration that fixes existing database values as well.
The two commits fix the theme settings admin pane (
theme-settings.php) and the interpretation of the value insidetemplate.phpBest regards and keep up the good work,
Lennart