Skip to content

Conversation

oegea
Copy link
Collaborator

@oegea oegea commented Sep 30, 2022

ISSUES CLOSED: #2333

molecule/buttonGroup

❓ Ask

TASK: #2333

Types of changes

  • 🧠 Refactor

Description, Motivation and Context

This PRs replaces cloneElementstatements from molecule/buttonGroup in favor of using the sui Injector component.
Submitted for the hacktoberfest event. It should not have any visual effect, just a refactor.

…injector in molecule/buttonGrou

ISSUES CLOSED: #2333
Copy link
Member

@andresin87 andresin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0.02↑ ≍ 0.1↑ ≍ 0.09↑ ≍ 0.09↑
% 72.03 57.69 58.94 73.69
ABS 2597 / 3605 1459 / 2529 471 / 799 2504 / 3398

Copy link
Member

@andresin87 andresin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@andresin87 andresin87 added the hacktoberfest-accepted Accepted for hacktoberfest, merged or we will merge later label Oct 3, 2022
@SUI-Components SUI-Components deleted a comment from github-actions bot Oct 3, 2022
@SUI-Components SUI-Components deleted a comment from github-actions bot Oct 3, 2022
@SUI-Components SUI-Components deleted a comment from github-actions bot Oct 3, 2022
@oegea oegea merged commit 6bb4fd6 into master Oct 3, 2022
@oegea oegea deleted the refactor/2333-molecule-button-group-injector branch October 3, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest hacktoberfest-accepted Accepted for hacktoberfest, merged or we will merge later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ ButtonGroup cloneElement replace to Injector

2 participants