Skip to content

fix(components/atom/popover): arrow border color inherit from custom type #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix(components/atom/popover): arrow border color inherit from custom type #2439

merged 1 commit into from
Oct 25, 2022

Conversation

andresin87
Copy link
Member

atom/popover

🔍 Show

TASK:

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles

Description, Motivation and Context

The arrow's border color when using a defined custom type are not inheriting the proper color defied in its token

Screenshots - Animations

@andresin87 andresin87 self-assigned this Oct 25, 2022
@andresin87 andresin87 added hacktoberfest-accepted Accepted for hacktoberfest, merged or we will merge later hacktoberfest labels Oct 25, 2022
@andresin87 andresin87 linked an issue Oct 25, 2022 that may be closed by this pull request
🪲 arrow border color inherit from custom type #2440
Closed
7 tasks
@andresin87 andresin87 merged commit d0029f9 into master Oct 25, 2022
@andresin87 andresin87 deleted the fix/atom-popover-arrow-color-custom-type branch October 25, 2022 09:57
@github-actions
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0＝ ≍ 0＝ ≍ 0＝ ≍ 0＝
% 71.86 57.99 59.01 73.69
ABS 2654 / 3693 1513 / 2609 481 / 815 2560 / 3474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kikoruiz kikoruiz Awaiting requested review from kikoruiz kikoruiz is a code owner

@rmoralp rmoralp Awaiting requested review from rmoralp

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@arnau-rius arnau-rius Awaiting requested review from arnau-rius

Assignees

@andresin87 andresin87

Labels

hacktoberfest hacktoberfest-accepted Accepted for hacktoberfest, merged or we will merge later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🪲 arrow border color inherit from custom type

1 participant

@andresin87