Fine-tune codecov config and increase coverage #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 95.93% 92.88% -3.06%
==========================================
Files 16 6 -10
Lines 3467 1138 -2329
Branches 0 203 +203
==========================================
- Hits 3326 1057 -2269
+ Misses 141 45 -96
- Partials 0 36 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is probably needed because of SOAP dependency: https://codecov.freshdesk.com/support/solutions/articles/43000593943-files-not-showing-in-codecov-fixing-paths- Or I wonder if there's a better solution to making the SOAP script available... |
kyleaoman
changed the title
kyleaoman
changed the title
Because we have SOAP and swiftgalaxy repos side by side in CI we need to tell codecov to consider e.g. swiftgalaxy/swiftgalaxy/reader.py as swiftgalaxy/reader.py
kyleaoman
changed the title
|
100% coverage is within reach. Still need to go through iterator.py and halo_catalogues.py, but setting those aside for now, this is merge-able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like because swiftgalaxy exists in a subdirectory in CI this needs a prefix in the ignored paths.
Also codecov interface can't pull up source code.