This repository was archived by the owner on Jan 19, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api-editor/gui/src/common/MenuBar.tsx
@Masara @DavidTen1 Please use this as the basis going forward. It seems to roughly work as expected now but should be verified by unit tests before the PR is merged. |
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
fd2ecc5
to
c322fdd
Compare
45b614a
to
59f5b97
Compare
…ere at index 0 after filtering
jofaul
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - lots of code with no tests, but since this is the webapp where bugs are either obvious or impossible to find it should be fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #487.
Summary of Changes
class:xy
etc. filter with separate filtersis:class
andname:xy
annotation:any
annotation:@xy
Screenshots (if necessary)
Testing Instructions
cd api-editor/gui npm run dev