LibCpp2IL: Return empty array if number of read elements is 0 #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SamboyCoding merged 1 commit into SamboyCoding:development from commonuserlol:development

Sep 29, 2024

Contributor

commonuserlol commented Sep 28, 2024

If length is 0, indexing array at 1 is an exception

Cpp2IL/LibCpp2IL/Metadata/Il2CppMetadata.cs

Line 322 in 2f8e5b3

FillReadableArrayHereNoLock(arr, 1);

Fixes #342


          LibCpp2IL: Return empty array if number of read elements is 0

7ea3201

Fixes SamboyCoding#342

coveralls commented Sep 28, 2024

Pull Request Test Coverage Report for Build 11084184650

Details

1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 28.388%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
LibCpp2IL/Metadata/Il2CppMetadata.cs	1	2	50.0%

Totals
Change from base Build 11023494789:	0.005%
Covered Lines:	3342
Relevant Lines:	10041

💛 - Coveralls

SamboyCoding merged commit 0fc6a65 into SamboyCoding:development

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet