Process addresses in the Mach-O export trie as ULEB128 instead of LEB128 #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14016638949Details
💛 - Coveralls |
aldelaro5
force-pushed
the
fix-macho-export-trie
branch
from
0f2e76a to
53d7b36
Compare
SamboyCoding
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a problem I noticed with TUNIC, but probably other games where the program would report it found some thunks at addresses that made no sense like 0xFFFFFFFFFF something.
Turns out the issue is the addresses were read as LEB128, but the correct encoding is ULEB128. I checked multiple sources confirming they were indeed supposed to be unsigned and the addresses ended up being correct after the fix.