Support injecting anything #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamboyCoding
requested changes
May 15, 2025
| // Covariant return types are .NET 5.0+ | ||
| public override List<MethodAnalysisContext> Overrides { get; } = new(); | ||
| #else | ||
| public override IEnumerable<MethodAnalysisContext> Overrides => []; |
There was a problem hiding this comment.
This of course means you can't inject methods with custom overrides on netfx. Are we ok with that?
There was a problem hiding this comment.
What are the implications of this decision? For example, does MelonLoader use the .NET Framework release?
* Nested types * Events * Properties * Assemblies
* Also add hide by sig attribute for injected constructors
ds5678
force-pushed
the
injection-everything
branch
from
54df930 to
0cac266
Compare
SamboyCoding
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.