fix ArrayInterface.ismutable(::ArrayPartition) #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Jan 7, 2021
Yeah... ours came first and does the right thing though 😆 Agreed with Yingbo it should be a generated function and then it's good. |
ChrisRackauckas
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PartitionedArrayshould be considered "mutable" only, if all of its components are "mutable".Therefore the
ArrayInterface.ismutablehas been specialized for this case.This fixes a bug in SciML/OrdinaryDiffEq.jl#1322
Another question is the naming
ArrayInteface.ismutablewhich collides withBase.ismutableand returns different results.