Skip to content

fix recursivecopy #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

fix recursivecopy #139

merged 1 commit into from
Apr 25, 2021

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Apr 23, 2021

@jlchan
Copy link
Contributor

jlchan commented Apr 23, 2021

Should I add ArrayInterface.ismutable(x::StructArray) = true before marking SciML/OrdinaryDiffEq.jl#1386 as closed?

@ranocha
Copy link
Member Author

ranocha commented Apr 23, 2021

No, you don't need that - it's the default

@ranocha
Copy link
Member Author

ranocha commented Apr 23, 2021

SciML/OrdinaryDiffEq.jl#1386 should be closed once this PR is merged - you don't need to do this manually, i think

@jlchan
Copy link
Contributor

jlchan commented Apr 23, 2021

Thanks! Much appreciated

@jlchan jlchan mentioned this pull request Apr 23, 2021
Closed
@ChrisRackauckas ChrisRackauckas merged commit 6e779ac into SciML:master Apr 25, 2021
@ranocha ranocha deleted the hr/StructArrays branch April 27, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type of array changes when using non-standard array types
3 participants
@ranocha @jlchan @ChrisRackauckas