Remove unreachable code #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,11 +72,7 @@ Base.@propagate_inbounds function Base.getindex(A::AbstractDiffEqArray{T, N},sym | |||
| end | |||
|
|
|||
| if i === nothing | |||
| if issymbollike(i) && A.indepsym !== nothing && Symbol(i) == A.indepsym | |||
| A.t | |||
There was a problem hiding this comment.
did you try the independent variable and see what it does?
There was a problem hiding this comment.
I think that case is covered now. Added tests too.
ChrisRackauckas
approved these changes
Jul 12, 2021
YingboMa
reviewed
Jul 12, 2021
src/vector_of_array.jl
Outdated
| @@ -71,8 +71,8 @@ Base.@propagate_inbounds function Base.getindex(A::AbstractDiffEqArray{T, N},sym | |||
| i = sym | |||
| end | |||
|
|
|||
| if i === nothing | |||
| if issymbollike(i) && A.indepsym !== nothing && Symbol(i) == A.indepsym | |||
| if i == nothing | |||
There was a problem hiding this comment.
This is not recommended. Why do you need to use ==?
There was a problem hiding this comment.
Please see SciML/SciMLBase.jl#84 (comment) .
YingboMa
reviewed
Jul 12, 2021
Are you referring to the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SciML/SciMLBase.jl#83