Speed up some use cases of ArrayPartition
#163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first batch of changes related to #160 . Most changes are related to the fact that
map
is much more friendly to Julia compiler than broadcasting so I've replaced a bunch of unnecessary broadcasts withmap
. The other thing is that the loop in assignment broadcast is very problematic -- ideally compiler should be able to constant-propagateN
and unroll the loop but it seems that doing so breaks some other optimizations. This change helps a bit but it's still not enough.