Skip to content

fix Base.similar for VectorOfArray of AbstractArray{<:StaticArray} #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

fix Base.similar for VectorOfArray of AbstractArray{<:StaticArray} #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9b35d9
remove recursive `similar` broadcast
jlchan Feb 3, 2025
3f65897
restore original Base.similar behavior, specialize on StaticArrays
jlchan Feb 3, 2025
2ee1724
add tests
jlchan Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/vector_of_array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,12 @@ function Base.similar(vec::VectorOfArray{
return VectorOfArray(similar.(Base.parent(vec)))
end

function Base.similar(vec::VectorOfArray{
T, N, AT}) where {T, N, AT <: AbstractArray{<:StaticArraysCore.StaticVecOrMat{T}}}
# this avoids behavior such as similar(SVector) returning an MVector
return VectorOfArray(similar(Base.parent(vec)))
end

@inline function Base.similar(VA::VectorOfArray, ::Type{T} = eltype(VA)) where {T}
VectorOfArray(similar.(VA.u, T))
end
Expand Down
12 changes: 11 additions & 1 deletion test/copy_static_array_test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,14 @@ x = StructArray{SVector{2, Float64}}((randn(2), randn(2)))
vx = VectorOfArray(x)
vx2 = copy(vx) .+ 1
ans = vx .+ vx2
@test ans.u isa StructArray
@test ans.u isa StructArray

# check that Base.similar(VectorOfArray{<:StaticArray}) returns the
# same type as the original VectorOfArray
x_staticvector = [SVector(0.0, 0.0) for _ in 1:2]
x_structarray = StructArray{SVector{2, Float64}}((randn(2), randn(2)))
x_mutablefv = [MutableFV(1.0, 2.0)]
x_immutablefv = [ImmutableFV(1.0, 2.0)]
for vec in [x_staticvector, x_structarray, x_mutablefv, x_immutablefv]
@test typeof(similar(VectorOfArray(vec))) === typeof(VectorOfArray(vec))
end
Loading