Prepare for AdjointFactorization
#363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 57.92% 53.76% -4.16%
==========================================
Files 43 43
Lines 3289 3283 -6
==========================================
- Hits 1905 1765 -140
- Misses 1384 1518 +134
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the ground for JuliaLang/julia#46874. The addition of handling of transpose factorizations seems desirable (and necessary in the above mentioned PR) because real
LUprefers transpose over adjoints, in contrast to other factorizations.