pass progress_id for distinct progress logging #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 81.39% 81.76% +0.37%
==========================================
Files 11 11
Lines 1435 1437 +2
==========================================
+ Hits 1168 1175 +7
+ Misses 267 262 -5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pepijndevos
force-pushed
the
pv/progress
branch
from
4869320 to
ab75831
Compare
pepijndevos
force-pushed
the
pv/progress
branch
from
ab75831 to
a0beadb
Compare
|
FYI this still requires SciML/DiffEqBase.jl#939 to be actually usable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make each simulation have an unique progress logging ID, so when multiple simulations are run in parallel they don't override each other. Usage: SciML/SciMLBase.jl#514