Skip to content

Add repr_html for CubeLists #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Conversation

DPeterK
Copy link
Member

@DPeterK DPeterK commented May 15, 2019

As a (long-delayed) follow-on to a previous PR to add cube html repr (see #2918), this adds html repr functionality to CubeList objects. The html repr is designed to be reasonably simple, retaining the content of the original CubeList repr while adding an accordion effect that, when a cube in the list is clicked, expands to reveal the html repr of that cube.

@DPeterK
Copy link
Member Author

DPeterK commented May 15, 2019

For want of a properly interactive notebook that demonstrates this in operation, here's a static screengrab of what the repr looks like (with one cube in the list expanded to show the embedded cube repr):

Screenshot 2019-05-15 at 17 05 04

@bjlittle
Copy link
Member

bjlittle commented Jul 9, 2019

@DPeterK Fancy doing a re-base?

We just fixed the travis-ci tests on master, and I'm hoping this will tidy up your CI failures.

Reference #3349

@bjlittle
Copy link
Member

Ping @DPeterK 😉

@DPeterK
Copy link
Member Author

DPeterK commented Jul 15, 2019

@bjlittle ping noted; unfortunately I'm busy now! I'll see what I can do.

@bjlittle
Copy link
Member

@DPeterK No worries 😉

@DPeterK
Copy link
Member Author

DPeterK commented Aug 23, 2019

@bjlittle I did it 😁

@DPeterK
Copy link
Member Author

DPeterK commented Aug 23, 2019

... shame the tests still didn't pass 😢

Edit: but it looks like it's just a license header thing 🎉 I'll fix...

@DPeterK
Copy link
Member Author

DPeterK commented Aug 27, 2019

I've updated the CSS for the cubelist repr, including making use of jupyter variables to define elements of the style. This means the cubelist repr will correctly follow jupyter lab themes. When combined with #3380 the cubelist repr now looks like the following:

Light theme:
Screenshot 2019-08-27 at 15 32 16

Dark theme:
Screenshot 2019-08-27 at 15 31 57

@bjlittle
Copy link
Member

bjlittle commented Oct 2, 2019

@DPeterK Awesome, LGTM 👍

@bjlittle bjlittle merged commit 8ca7e85 into SciTools:master Oct 2, 2019
@DPeterK DPeterK deleted the cubelist_repr branch October 2, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants