Skip to content

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Aug 4, 2025

🚀 Pull Request

Description

This one was pretty tricky - a big file with lots of out-dated patterns!

I recommend reviewing each commit individually. Having to drop all the context managers (ad7c85d) meant unindenting a lot of lines, which confuses the rest of the 'narrative'.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers trexfeathers requested review from ESadek-MO and removed request for HGWright August 4, 2025 14:57
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (03c21c8) to head (ad7c85d).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6601   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          91       91           
  Lines       24447    24447           
  Branches     4567     4567           
=======================================
  Hits        21992    21992           
  Misses       1686     1686           
  Partials      769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ESadek-MO ESadek-MO self-assigned this Aug 7, 2025
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers!

Passes the checklist run through, nothing stands out, good to go!

@ESadek-MO ESadek-MO enabled auto-merge (squash) August 7, 2025 15:36
@ESadek-MO ESadek-MO merged commit d2db369 into SciTools:main Aug 7, 2025
22 checks passed
@ESadek-MO ESadek-MO mentioned this pull request Aug 4, 2025
10 tasks
@trexfeathers trexfeathers deleted the pytest_root_netcdf branch August 22, 2025 13:54
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants