-
Notifications
You must be signed in to change notification settings - Fork 297
Convert test_cartography
, test_cdm
, test_cell
to PyTest
#6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6609 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 91 91
Lines 24447 24447
Branches 4567 4567
=======================================
Hits 21992 21992
Misses 1686 1686
Partials 769 769 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of bad patterns.
Note that some of these patterns I've only commented on one, but appear multiple times, throughout multiple files! Also, in some files, the pytest.raises
is fine in places, but wrong in others. I'd double check the whole file just to make sure it's not inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing came up in the checklist, it's minor, I'm just using this PR to agree a policy on things like this.
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trexfeathers!
For future reference, we decided offline that if it's an easy change, we should do our best to enforce small consistency rules (such as _setup(self)
, for neatness etc.
No description provided.