Skip to content

Conversation

trexfeathers
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (09feafe) to head (07744a4).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6609   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          91       91           
  Lines       24447    24447           
  Branches     4567     4567           
=======================================
  Hits        21992    21992           
  Misses       1686     1686           
  Partials      769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ESadek-MO ESadek-MO self-assigned this Aug 7, 2025
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of bad patterns.

Note that some of these patterns I've only commented on one, but appear multiple times, throughout multiple files! Also, in some files, the pytest.raises is fine in places, but wrong in others. I'd double check the whole file just to make sure it's not inconsistent.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing came up in the checklist, it's minor, I'm just using this PR to agree a policy on things like this.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers!

For future reference, we decided offline that if it's an easy change, we should do our best to enforce small consistency rules (such as _setup(self), for neatness etc.

@ESadek-MO ESadek-MO enabled auto-merge (squash) August 11, 2025 10:18
@ESadek-MO ESadek-MO merged commit dc0cddb into SciTools:main Aug 11, 2025
21 checks passed
@ESadek-MO ESadek-MO mentioned this pull request Aug 4, 2025
10 tasks
@trexfeathers trexfeathers deleted the pytest_root_3 branch August 22, 2025 13:53
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants