Skip to content

Upper bound dependencies, add dependabot integration #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2021

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Feb 15, 2021

Motivation is the same as in SeldonIO/alibi#349 .

The only dependency I'm uncertain of is dask. First, not sure what the lower bound should be (I set it from what I had in my environment), second, they switched to calver (dask/community#100) citing in part the ability to have breaking changes in releases. Now, this doesn't mean we should have an upper bound for every version as most likely there will be no breaking changes, but do we have an arbitrary upper bound (e.g. year 2022 as proposed) or just not have an upper bound for dask?

Finally, I cleaned up some entries in setup.py which are not relevant as we don't run tests using python setup.py test anymore (same behaviour as alibi).

@jklaise jklaise mentioned this pull request Feb 15, 2021
@jklaise
Copy link
Contributor Author

jklaise commented Feb 16, 2021

We could also upper bound tensorflow at 3.0.0 if we trust them not breaking between minor versions.

@arnaudvl arnaudvl merged commit 826113c into SeldonIO:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants