Update use-aadhttpclient.md #10316
Merged
Update use-aadhttpclient.md #10316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed note to indicate MSAL is not to be directly used in SPFx due to conflicts, use AADHttpClient instead.
|
Learn Build status updates of commit ec4ea19:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/spfx/use-aadhttpclient.md | View | Details |
docs/spfx/use-aadhttpclient.md
- Line 21, Column 68: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/javascript/api/overview/msal-overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 21, Column 68: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/javascript/api/overview/msal-overview' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
- replace "Azure AD" with "Entra ID" & related references - update doc timestamp - fix grammar - remove locale from URL
andrewconnell
approved these changes
Jul 2, 2025
|
Learn Build status updates of commit 12b996f:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/spfx/release-1.15.2.md | View | Details | |
| docs/spfx/use-microsoft-graph-toolkit.md | View | Details | |
| docs/spfx/use-aadhttpclient.md | 💡Suggestion | View | Details |
docs/spfx/release-1.15.2.md
- Line 53, Column 44: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#requesting-permissions-to-azure-ad-applications-in-another-tenant' in 'spfx/use-aadhttpclient.md', did you mean '#requesting-permissions-to-entra-id-applications-in-another-tenant'?
docs/spfx/use-microsoft-graph-toolkit.md
- Line 59, Column 101: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#request-permissions-to-an-azure-ad-application' in 'spfx/use-aadhttpclient.md', did you mean '#request-permissions-to-an-entra-id-application'?
docs/spfx/use-aadhttpclient.md
- Line 21, Column 70: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/javascript/api/overview/msal-overview' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
andrewconnell
added
pr:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed note to indicate MSAL is not to be directly used in SPFx due to conflicts, use AADHttpClient instead.
Category
What's in this Pull Request?
change to use-aadhttpclient.md, to recommend not to use MSAL directly due to conflicts with SPFx version of MSAL.